Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Proposal for UpstreamSettingsPolicy #2489

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

sjberman
Copy link
Contributor

Problem: As a user, I want to be able to configure settings for connection from NGF to an upstream application.

Solution: Submit the enhancement proposal for the UpstreamSettingsPolicy.

Closes #2368

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: As a user, I want to be able to configure settings for connection from NGF to an upstream application.

Solution: Submit the enhancement proposal for the UpstreamSettingsPolicy.
@sjberman sjberman requested review from a team as code owners August 30, 2024 14:55
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 30, 2024
@sjberman sjberman requested a review from mpstefan August 30, 2024 14:55
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (e3a53b3) to head (364b5dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2489   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files         100      100           
  Lines        7539     7539           
  Branches       50       50           
=======================================
  Hits         6726     6726           
  Misses        756      756           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/proposals/upstream-settings.md Show resolved Hide resolved
docs/proposals/upstream-settings.md Show resolved Hide resolved
docs/proposals/upstream-settings.md Show resolved Hide resolved
docs/proposals/upstream-settings.md Outdated Show resolved Hide resolved
docs/proposals/upstream-settings.md Outdated Show resolved Hide resolved
@sjberman sjberman requested a review from kate-osborn August 30, 2024 18:58
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once those changes are in!

Copy link
Collaborator

@mpstefan mpstefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also like how we are following the pattern of updating objects with a label even at the Route level.

@sjberman sjberman merged commit 2544818 into nginxinc:main Sep 4, 2024
37 checks passed
@sjberman sjberman deleted the docs/upstream-policy branch September 4, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Design for Upstream Settings Policy
5 participants