-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement Proposal for UpstreamSettingsPolicy #2489
Conversation
Problem: As a user, I want to be able to configure settings for connection from NGF to an upstream application. Solution: Submit the enhancement proposal for the UpstreamSettingsPolicy.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2489 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 100 100
Lines 7539 7539
Branches 50 50
=======================================
Hits 6726 6726
Misses 756 756
Partials 57 57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once those changes are in!
Co-authored-by: bjee19 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Also like how we are following the pattern of updating objects with a label even at the Route level.
Problem: As a user, I want to be able to configure settings for connection from NGF to an upstream application.
Solution: Submit the enhancement proposal for the UpstreamSettingsPolicy.
Closes #2368
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.