Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SnippetFilter validation rules in enhancement proposal #2471

Merged

Conversation

kate-osborn
Copy link
Contributor

@kate-osborn kate-osborn commented Aug 27, 2024

Proposed changes

Problem: The advanced nginx extensions proposal doesn't provide guidance on handling routes that reference invalid or nonexistent SnippetFilters.

Solution: Add guidance on handling these cases to the enhancement proposal. The guidance is based off the Gateway API spec documentation.

Closes #2468

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

None

@kate-osborn kate-osborn requested review from a team as code owners August 27, 2024 20:03
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Aug 27, 2024
@bjee19
Copy link
Contributor

bjee19 commented Aug 27, 2024

@kate-osborn the link to the closed issue points to a closed PR instead of #2468.

@kate-osborn kate-osborn requested a review from bjee19 August 28, 2024 17:01
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (1e65743) to head (c7219fa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2471   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files         100      100           
  Lines        7531     7531           
  Branches       50       50           
=======================================
  Hits         6687     6687           
  Misses        788      788           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kate-osborn kate-osborn force-pushed the chore/update-snippetsfilter-proposal branch from 08272a8 to c7219fa Compare August 28, 2024 18:48
@kate-osborn kate-osborn merged commit 4edca82 into nginxinc:main Aug 28, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update Advanced NGINX Extensions Design
3 participants