-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fail-fast flag to ginkgo tests #2389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjberman
reviewed
Aug 13, 2024
Should we close this? |
Do we want to do it just for unit tests? |
Sure |
Problem: When a test is failing the rest of the tests will still keep running. Solution: Add fail-fast flag so that the tests will stop and will make it easier to analyze the error.
lucacome
force-pushed
the
tests/add-fail-fast
branch
from
August 22, 2024 18:28
c9294f8
to
210b55c
Compare
sjberman
approved these changes
Aug 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2389 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 100 100
Lines 7531 7531
Branches 50 50
=======================================
Hits 6687 6687
Misses 788 788
Partials 56 56 ☔ View full report in Codecov by Sentry. |
kate-osborn
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: When a test is failing the rest of the tests will still keep running.
Solution: Add fail-fast flag so that the tests will stop and will make it easier to analyze the error.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.