Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fail-fast flag to ginkgo tests #2389

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

Problem: When a test is failing the rest of the tests will still keep running.

Solution: Add fail-fast flag so that the tests will stop and will make it easier to analyze the error.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner August 13, 2024 19:10
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 13, 2024
tests/Makefile Outdated Show resolved Hide resolved
@kate-osborn
Copy link
Contributor

Should we close this?

@lucacome
Copy link
Member Author

Do we want to do it just for unit tests?

@kate-osborn
Copy link
Contributor

Do we want to do it just for unit tests?

Sure

Problem: When a test is failing the rest of the tests will still keep
running.

Solution: Add fail-fast flag so that the tests will stop and will make
it easier to analyze the error.
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (1af04e8) to head (1ba8f5d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2389   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files         100      100           
  Lines        7531     7531           
  Branches       50       50           
=======================================
  Hits         6687     6687           
  Misses        788      788           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome enabled auto-merge (squash) August 27, 2024 20:34
@lucacome lucacome merged commit 9200847 into nginxinc:main Aug 27, 2024
37 checks passed
@lucacome lucacome deleted the tests/add-fail-fast branch August 27, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants