Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove var buildInfo #2358

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Remove var buildInfo #2358

merged 2 commits into from
Aug 9, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Aug 9, 2024

Proposed changes

Problem: Running the tests in parallel would cause a data race, because the tests were all trying to write the same variable.

Solution: Remove the var and type, that were only used for tests and use the actual build info to test that the function works correctly.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner August 9, 2024 00:02
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (8753459) to head (ae5b4c9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2358      +/-   ##
==========================================
- Coverage   88.88%   88.85%   -0.03%     
==========================================
  Files         100      100              
  Lines        7509     7509              
  Branches       50       50              
==========================================
- Hits         6674     6672       -2     
- Misses        780      781       +1     
- Partials       55       56       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Problem: Running the tests in parallel would cause a data race, because
the tests were all trying to write the same variable.

Solution: Remove the var and type, that were only used for tests and use
the actual build info to test that the function works correctly.
@lucacome lucacome requested review from sjberman and a team August 9, 2024 16:58
@lucacome lucacome enabled auto-merge (squash) August 9, 2024 17:49
@lucacome lucacome merged commit aedc18d into nginxinc:main Aug 9, 2024
35 checks passed
@lucacome lucacome deleted the chore/debug-info branch August 9, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants