-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Client IP Enhancement Proposal #2329
Rewrite Client IP Enhancement Proposal #2329
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
=======================================
Coverage 87.74% 87.74%
=======================================
Files 96 96
Lines 6830 6830
Branches 50 50
=======================================
Hits 5993 5993
Misses 780 780
Partials 57 57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work 👏
026e131
to
556e732
Compare
Love the use case approach. Recursive is still weird, but I'm good with exposing it in the API as long as it's optional. NGINX directive approach sounds pretty similar to our NGINX customization that we plan to deliver next release, so I don't think we'd ever need to follow that pattern... Thanks for the write-up, Kate! |
Co-authored-by: Saylor Berman <[email protected]>
Co-authored-by: Saylor Berman <[email protected]>
556e732
to
2eda31f
Compare
Proposed changes
Problem:
As a user of NGF
I want to rewrite the client's IP address to the original client's IP
When fronting NGF with a LoadBalancer
So that the real client's IP address is forwarded to my application
Or so that I can log the client's IP address.
Solution: Add a design for rewriting the client's IP address
Closes #2328
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.