Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly disable leader election #2307

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

sjberman
Copy link
Contributor

Problem: NGF does not honor the --leader-election-disable command-line flag.

Solution: Use the proper variable instead of a hardcoded boolean.

Testing: Verified that disabling leader election actually disables it.

Closes #2283

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Fix bug where leader election couldn't be disabled.

Problem: NGF does not honor the `--leader-election-disable` command-line flag.

Solution: Use the proper variable instead of a hardcoded boolean.
@sjberman sjberman requested a review from a team as a code owner July 29, 2024 20:14
@github-actions github-actions bot added the bug Something isn't working label Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.76%. Comparing base (bfd25a5) to head (b691686).

Files Patch % Lines
internal/mode/static/manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2307   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          96       96           
  Lines        6793     6793           
  Branches       50       50           
=======================================
  Hits         5962     5962           
  Misses        774      774           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman
Copy link
Contributor Author

At some point we should probably figure out a good way to unit test all this manager setup.

@sjberman sjberman enabled auto-merge (squash) July 29, 2024 21:40
@sjberman sjberman merged commit 92db570 into nginxinc:main Jul 29, 2024
36 of 37 checks passed
@sjberman sjberman deleted the fix/leader-election branch July 29, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Leader election cannot be disabled
3 participants