Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom NGF Debian image for tests #2260

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jul 18, 2024

Proposed changes

Problem: We're using a specific version of debian to create the VM. This image is deprecated. We also install all the dependencies needed every time we create the VM.

Solution: Create a custom image with all our dependencies and specify the image-family as a parameter so we can always use the latest version.

First pass at https://github.com/nginxinc/k8s-dev/issues/80 I think I'll probably upload the source code for building the image to https://github.com/nginxinc/k8s-common unless we want it in this repo.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner July 18, 2024 22:25
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (57ab5e9) to head (8cb27a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2260   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          96       96           
  Lines        6793     6793           
  Branches       50       50           
=======================================
  Hits         5962     5962           
  Misses        774      774           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman
Copy link
Contributor

I'm assuming this is a manually built image that you've pushed right now? If so, I'd rather wait to remove this stuff until that image can be easily updated by anyone through some script/process.

This way we aren't blocked or limited by any one person who has to build it and push it.

@lucacome lucacome force-pushed the chore/ngf-image branch 2 times, most recently from a69517f to b74f425 Compare July 18, 2024 22:40
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jul 18, 2024
@lucacome
Copy link
Member Author

@sjberman I have a configuration for packer. I was planning to push it to https://github.com/nginxinc/k8s-common since it just creates a debian image with helm, kubectl, go, etc. installed, nothing specific for this repo.

The next step is to automate the creation of that image to keep it up-to-date, but I don't think it's really urgent since it would just update the base image and the version of the tools. So we should be good for a while.

@lucacome lucacome force-pushed the chore/ngf-image branch 2 times, most recently from 0507f84 to 26bffd2 Compare July 23, 2024 18:29
Problem: We're using a specific version of debian to create the VM. This
image is deprecated. We also install all the dependencies needed every
time we create the VM.

Solution: Create a custom image with all of our dependencies and specify
the image-family as a parameter so we can always use the latest version.
@lucacome lucacome merged commit 1476fe0 into nginxinc:main Jul 23, 2024
37 checks passed
@lucacome lucacome deleted the chore/ngf-image branch July 23, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants