-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom NGF Debian image for tests #2260
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2260 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 96 96
Lines 6793 6793
Branches 50 50
=======================================
Hits 5962 5962
Misses 774 774
Partials 57 57 ☔ View full report in Codecov by Sentry. |
I'm assuming this is a manually built image that you've pushed right now? If so, I'd rather wait to remove this stuff until that image can be easily updated by anyone through some script/process. This way we aren't blocked or limited by any one person who has to build it and push it. |
a69517f
to
b74f425
Compare
a756781
to
9cbdfeb
Compare
@sjberman I have a configuration for packer. I was planning to push it to https://github.com/nginxinc/k8s-common since it just creates a debian image with The next step is to automate the creation of that image to keep it up-to-date, but I don't think it's really urgent since it would just update the base image and the version of the tools. So we should be good for a while. |
0507f84
to
26bffd2
Compare
Problem: We're using a specific version of debian to create the VM. This image is deprecated. We also install all the dependencies needed every time we create the VM. Solution: Create a custom image with all of our dependencies and specify the image-family as a parameter so we can always use the latest version.
26bffd2
to
8cb27a9
Compare
Proposed changes
Problem: We're using a specific version of debian to create the VM. This image is deprecated. We also install all the dependencies needed every time we create the VM.
Solution: Create a custom image with all our dependencies and specify the image-family as a parameter so we can always use the latest version.
First pass at https://github.com/nginxinc/k8s-dev/issues/80 I think I'll probably upload the source code for building the image to https://github.com/nginxinc/k8s-common unless we want it in this repo.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.