Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/add runtime manager tests #2175

Merged
merged 28 commits into from
Aug 29, 2024

Conversation

miledxz
Copy link
Contributor

@miledxz miledxz commented Jun 27, 2024

Proposed changes

Reopening pr trough another pr because issues on github

update on this: #1555, since I did mistake and discarded all commits,
I haven't find better solution so I opened another pr @sjberman @kate-osborn

Closes #1498

  • [ x] I have read the CONTRIBUTING doc
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] I have checked that all unit tests pass after adding my changes
  • [ x] I have updated necessary documentation
  • [ x] I have rebased my branch onto main
  • [ x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@miledxz miledxz requested a review from a team as a code owner June 27, 2024 10:30
@github-actions github-actions bot added the tests Pull requests that update tests label Jun 27, 2024
internal/mode/static/manager.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager_test.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager_test.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager_test.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/verify.go Outdated Show resolved Hide resolved
@miledxz miledxz force-pushed the test/add-runtime-manager-tests branch from 218715f to ec0048d Compare June 29, 2024 12:35
@miledxz miledxz requested a review from kate-osborn June 29, 2024 12:37
internal/mode/static/manager.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager_test.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager_test.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager_test.go Outdated Show resolved Hide resolved
@miledxz miledxz force-pushed the test/add-runtime-manager-tests branch 4 times, most recently from da784fc to e0d5d1c Compare July 7, 2024 13:25
@miledxz miledxz force-pushed the test/add-runtime-manager-tests branch from e0d5d1c to 7f6d1bf Compare July 7, 2024 13:30
@miledxz miledxz requested a review from kate-osborn August 11, 2024 10:24
@miledxz miledxz force-pushed the test/add-runtime-manager-tests branch from fe8d2fc to 547e903 Compare August 11, 2024 11:00
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.

Project coverage is 89.21%. Comparing base (767294e) to head (8913e20).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/mode/static/manager.go 0.00% 5 Missing ⚠️
internal/mode/static/nginx/runtime/manager.go 75.00% 4 Missing ⚠️
internal/mode/static/nginx/runtime/verify.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2175      +/-   ##
==========================================
+ Coverage   88.79%   89.21%   +0.42%     
==========================================
  Files         100      100              
  Lines        7531     7539       +8     
  Branches       50       50              
==========================================
+ Hits         6687     6726      +39     
+ Misses        788      756      -32     
- Partials       56       57       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miledxz miledxz force-pushed the test/add-runtime-manager-tests branch from 1318e1b to 2626ca2 Compare August 20, 2024 17:03
@miledxz miledxz requested a review from kate-osborn August 20, 2024 17:05
internal/mode/static/nginx/runtime/manager.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/runtime/manager.go Outdated Show resolved Hide resolved
@miledxz miledxz force-pushed the test/add-runtime-manager-tests branch from 2626ca2 to 8b94a05 Compare August 20, 2024 18:45
@miledxz
Copy link
Contributor Author

miledxz commented Aug 20, 2024

latest updates are in this commit: 8b94a05

@miledxz miledxz requested a review from kate-osborn August 20, 2024 19:07
@miledxz miledxz requested a review from kate-osborn August 21, 2024 19:43
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miledxz there are a couple of issues in the pipeline. See my other comment for details: #2175 (comment)

@miledxz
Copy link
Contributor Author

miledxz commented Aug 29, 2024

@kate-osborn added lint fix update, take a look when u have time

@miledxz miledxz requested a review from kate-osborn August 29, 2024 17:56
@miledxz miledxz force-pushed the test/add-runtime-manager-tests branch from 7154d57 to 1a56441 Compare August 29, 2024 19:07
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kate-osborn kate-osborn requested a review from sjberman August 29, 2024 19:37
Copy link

nginx-bot bot commented Aug 29, 2024

Hi @miledxz! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

@sjberman sjberman enabled auto-merge (squash) August 29, 2024 20:47
@sjberman sjberman merged commit 33304b6 into nginxinc:main Aug 29, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add unit tests for nginx runtime manager
5 participants