From 1786098b25cd6af0f079d3be117e6e28f4d5a77e Mon Sep 17 00:00:00 2001 From: Michael Pleshakov Date: Thu, 30 May 2024 17:09:28 -0400 Subject: [PATCH] Fix longevity test runs Problem: Running longevity test mistakenly runs all other NFRs make start-longevity-test and make stop-longevity-test mistakenly executes all NFRs. Only longevity test must run. Solution: Problem was introduced in 8671fb7 Ensure the env variables are exported so that they are passed to nfr-test target. Testing: - Ran make start-longevity-test and make stop-longevity-test successfully. CLOSES - https://github.com/nginxinc/nginx-gateway-fabric/issues/2064 --- tests/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index b7b08e2883..7aba9fafb2 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -100,11 +100,11 @@ nfr-test: ## Run the NFR tests on a GCP VM NFR=true bash scripts/run-tests-gcp-vm.sh .PHONY: start-longevity-test -start-longevity-test: START_LONGEVITY=true +start-longevity-test: export START_LONGEVITY=true start-longevity-test: nfr-test ## Start the longevity test to run for 4 days in GKE .PHONY: stop-longevity-test -stop-longevity-test: STOP_LONGEVITY=true +stop-longevity-test: export STOP_LONGEVITY=true stop-longevity-test: nfr-test ## Stop the longevity test and collects results .PHONY: .vm-nfr-test