Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom annotations into GatewayClass and NginxGateway manifests #1993

Merged
merged 12 commits into from
Jun 3, 2024

Conversation

sgavrylenko
Copy link
Contributor

Proposed changes

Based on previous accidentally closed PR-1899

Add custom annotations for GatewayClass and NginxGateway objects.
It can be useful in different cases

Problem: For deploying our service we use ArgoCD. For this, we have a Helm Chart that contains multiple resources that are using CRDs, that are not managed by this helm chart. When trying to sync this application, it fails if at least one CRD is not installed in the cluster. This is expected.

Solution: To work around this problem, we want to use SkipDryRunOnMissingResource option as annotation for GatewayClass and NginxGateway objects from the nginx-gateway-fabric chart

Testing: Helm template works fine.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@sgavrylenko sgavrylenko requested a review from a team as a code owner May 20, 2024 15:02
@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels May 20, 2024
charts/nginx-gateway-fabric/README.md Outdated Show resolved Hide resolved
charts/nginx-gateway-fabric/README.md Outdated Show resolved Hide resolved
@sgavrylenko sgavrylenko requested a review from salonichf5 May 21, 2024 05:14
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (118488e) to head (c795322).

Current head c795322 differs from pull request most recent head bc40b77

Please upload reports for the commit bc40b77 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1993      +/-   ##
==========================================
+ Coverage   87.61%   87.66%   +0.04%     
==========================================
  Files          96       93       -3     
  Lines        6694     6557     -137     
  Branches       50       50              
==========================================
- Hits         5865     5748     -117     
+ Misses        773      753      -20     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome enabled auto-merge (squash) June 3, 2024 16:31
@lucacome lucacome changed the title Add custom annotations into GatewayClass and NginxGateway manifests (reopened) Add custom annotations into GatewayClass and NginxGateway manifests Jun 3, 2024
@lucacome lucacome merged commit cecf9ec into nginxinc:main Jun 3, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants