Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gateway API to v1.1.0 #1975

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

ciarams87
Copy link
Member

Proposed changes

Problem: We don't support the latest version of the Gateway API (v1.1.0)

Solution: Upgrade to the latest version. As part of this upgrade, we must/ can:

  • Upgrade BackendTLSPolicy to v1alpha3 (breaking change, required)
  • Upgrade GRPCRoute to v1 (this means it does not need to be behind the experimental flag, and we don't need to support v1alpha2 of the API)
  • Enable the GRPCRoute Conformance tests
  • PolicyTargetReference has been removed, so use LocalPolicyTargetReference for the target refs in our new policies (can optionally use NamespacedPolicyTargetReference instead, but we already have the requirement of the targets being in the same namespace as the policies)
  • Fix the conformance tests to run on the latest version, which also means the main Gateway API branch in the nightly run is fixed

Testing: Ran the full conformance test suite, including the GRPCRoute tests. Locally tested the BackendTLSPolicy workflow following the guide.

Closes #1970

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Updated to v1.1.0 of the Gateway API. This includes a breaking change to BackendTLSPolicies - see [the release notes](https://github.com/kubernetes-sigs/gateway-api/releases/tag/v1.1.0) for further details

@ciarams87 ciarams87 requested review from a team as code owners May 15, 2024 17:30
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file helm-chart Relates to helm chart labels May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 97.18310% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.03%. Comparing base (aa16231) to head (7839f55).

Files Patch % Lines
internal/mode/provisioner/manager.go 0.00% 1 Missing ⚠️
internal/mode/static/manager.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1975      +/-   ##
==========================================
+ Coverage   86.98%   87.03%   +0.04%     
==========================================
  Files          89       89              
  Lines        6091     6091              
  Branches       50       50              
==========================================
+ Hits         5298     5301       +3     
+ Misses        741      737       -4     
- Partials       52       53       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table on our top-level README also needs to be updated

@ciarams87 ciarams87 force-pushed the feat/upgrade-gw-api branch 2 times, most recently from d76f843 to b802280 Compare May 16, 2024 10:29
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM docs-wise!

@ciarams87 ciarams87 force-pushed the feat/upgrade-gw-api branch 2 times, most recently from 8a798da to de0df2f Compare May 16, 2024 14:35
@ciarams87 ciarams87 requested a review from sjberman May 16, 2024 15:47
@ciarams87 ciarams87 force-pushed the feat/upgrade-gw-api branch from de0df2f to 7839f55 Compare May 16, 2024 17:30
@ciarams87 ciarams87 enabled auto-merge (squash) May 16, 2024 17:31
@ciarams87 ciarams87 merged commit c420eaa into nginxinc:main May 16, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart release-notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Upgrade Gateway API to v1.1.0
5 participants