-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Gateway API to v1.1.0 #1975
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1975 +/- ##
==========================================
+ Coverage 86.98% 87.03% +0.04%
==========================================
Files 89 89
Lines 6091 6091
Branches 50 50
==========================================
+ Hits 5298 5301 +3
+ Misses 741 737 -4
- Partials 52 53 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Table on our top-level README also needs to be updated
d76f843
to
b802280
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM docs-wise!
8a798da
to
de0df2f
Compare
de0df2f
to
7839f55
Compare
Proposed changes
Problem: We don't support the latest version of the Gateway API (v1.1.0)
Solution: Upgrade to the latest version. As part of this upgrade, we must/ can:
PolicyTargetReference
has been removed, so useLocalPolicyTargetReference
for the target refs in our new policies (can optionally useNamespacedPolicyTargetReference
instead, but we already have the requirement of the targets being in the same namespace as the policies)Testing: Ran the full conformance test suite, including the GRPCRoute tests. Locally tested the BackendTLSPolicy workflow following the guide.
Closes #1970
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.