-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect backendTLSPolicy and GRPCRoute Count #1954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
May 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1954 +/- ##
==========================================
+ Coverage 87.03% 87.04% +0.01%
==========================================
Files 89 89
Lines 6091 6096 +5
Branches 50 50
==========================================
+ Hits 5301 5306 +5
Misses 737 737
Partials 53 53 ☔ View full report in Codecov by Sentry. |
kate-osborn
reviewed
May 14, 2024
kate-osborn
requested changes
May 15, 2024
kate-osborn
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sjberman
reviewed
May 15, 2024
ciarams87
approved these changes
May 16, 2024
sjberman
approved these changes
May 16, 2024
bjee19
approved these changes
May 16, 2024
Co-authored-by: Kate Osborn <[email protected]>
salonichf5
force-pushed
the
feat/enhance-telemetry
branch
from
May 16, 2024 22:17
bd18a6e
to
836a5c8
Compare
ADubhlaoich
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
release-notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As a maintainer of NGF
I want to collect the GRPCRoute and BackendTLSPolicy count from all NGF/NIC installations
So that I can understand many GRPCRoute and BackendTLSPolicy are being configured using NGF.
Solution: Adding two new fields
GRPCRouteCount
,BackendTLSPolicyCount
to telemetry data collector.Testing: Manual Testing
No GRPCRoute and BackendPolicy is configured
With 4 GRPCRoute configured following example
With GRPCRoute and BackendTLSPolicy configured
Closes #1615
Closes #1839
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.