-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add directive for SSL Server block #1934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you update the release note section in the PR description to say something like "Fixed issue when using BackendTLSPolicy that led to failed connections." |
sjberman
reviewed
May 7, 2024
sjberman
reviewed
May 7, 2024
Be sure to re-verify with the BackendTLSPolicy example to ensure it works. |
salonichf5
force-pushed
the
bug/backend-tls
branch
from
May 7, 2024 18:20
aa21ef3
to
4c5f48a
Compare
Yes, just verified it with the new location and if it picks the right path
|
sjberman
approved these changes
May 7, 2024
salonichf5
force-pushed
the
bug/backend-tls
branch
from
May 7, 2024 18:40
b289b26
to
c2c8289
Compare
salonichf5
force-pushed
the
bug/backend-tls
branch
from
May 7, 2024 18:41
c2c8289
to
694817b
Compare
kate-osborn
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: Users want to configure BackendTLS successfully with NGF.
Solution: Adds a directive
proxy_ssl_server_name on
in the server location block to avoid connection resets during SSL handshake.Testing: Manual testing by installing NGF and verifying
/etc/nginx/nginx.conf
. Working with examplenginx.conf
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #1836
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.