Automate scale test #1926
Merged
Automate scale test #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sjberman
reviewed
May 2, 2024
kate-osborn
requested changes
May 14, 2024
pleshakov
force-pushed
the
tests/automate-scale-test
branch
from
3d61535 to
e216554
Compare
sjberman
reviewed
May 16, 2024
sjberman
reviewed
May 16, 2024
|
If you wanted to verify that this test can be run in the pipeline and close out #1927, you could create this branch on the upstream repo and then run the workflow on that branch. |
sjberman
approved these changes
May 16, 2024
ciarams87
approved these changes
May 17, 2024
sjberman
reviewed
May 17, 2024
Problem: Non-functional scale test needs to be run manually. Solution: - Automate scale test. - Use in-cluster Prometheus to collect CPU, memory and NGF metrics. - Use Kubernetes API server to get NGF logs. For development and troubleshooting, it is possible to run scale test locally in Kind cluster. However, it is necessary to bring down the number of HTTPRoutes to 50 or less (roughly). Testing: - Ran this test locally with 64 listeners, 50 routes and 50 upstreams with NGINX OSS. - Ran this test on GKE with the default configuration with NGINX OSS. Out of scope: ensuring this test runs successfully via GitHub pipeline. Closes nginxinc#1368 Largely based on work by Ciara in nginxinc#1804 Co-authored-by: Ciara Stacke <[email protected]>
…ects when a test fails
…(those errors ask users to configure usage reporting, which we don't need for tests)
pleshakov
force-pushed
the
tests/automate-scale-test
branch
from
83fc7bd to
0a4680e
Compare
github-actions
bot
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
Non-functional scale test needs to be run manually.
Solution:
For development and troubleshooting, it is possible to run scale test locally in Kind cluster. However, it is necessary to bring down the number of HTTPRoutes to 50 or less (roughly).
Testing:
Out of scope: ensuring this test runs successfully via GitHub pipeline -- #1927
Closes #1368
Largely based on work by Ciara in
#1804
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.