Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate functional test in the pipeline #1634

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Automate functional test in the pipeline #1634

merged 8 commits into from
Mar 12, 2024

Conversation

salonichf5
Copy link
Contributor

@salonichf5 salonichf5 commented Mar 1, 2024

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: As a user, I want to automate functional tests in the pipeline

Solution: To run functional tests in the pipeline, we introduce a new github workflow that sets up the environment to run tests, and upload results

Testing: Manual testing by pushing to the branch

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #1562

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 1, 2024
@salonichf5 salonichf5 changed the title Functional test Automate functional test in the pipeline Mar 1, 2024
@salonichf5 salonichf5 force-pushed the functional-test branch 4 times, most recently from 5a34ee8 to de30454 Compare March 7, 2024 21:03
@salonichf5 salonichf5 marked this pull request as ready for review March 7, 2024 21:31
@salonichf5 salonichf5 requested a review from a team as a code owner March 7, 2024 21:31
tests/Makefile Outdated Show resolved Hide resolved
tests/Makefile Outdated Show resolved Hide resolved
tests/Makefile Outdated Show resolved Hide resolved
tests/Makefile Outdated Show resolved Hide resolved
.github/workflows/functional.yml Show resolved Hide resolved
.github/workflows/functional.yml Outdated Show resolved Hide resolved
.github/workflows/functional.yml Outdated Show resolved Hide resolved
.github/workflows/functional.yml Outdated Show resolved Hide resolved
.github/workflows/functional.yml Outdated Show resolved Hide resolved
.github/workflows/functional.yml Outdated Show resolved Hide resolved
.github/workflows/functional.yml Outdated Show resolved Hide resolved
conformance/README.md Outdated Show resolved Hide resolved
@salonichf5 salonichf5 self-assigned this Mar 8, 2024
@salonichf5 salonichf5 requested review from pleshakov and sjberman March 8, 2024 19:40
.github/workflows/functional.yml Outdated Show resolved Hide resolved
.github/workflows/functional.yml Outdated Show resolved Hide resolved
.github/workflows/functional.yml Outdated Show resolved Hide resolved
@salonichf5 salonichf5 requested a review from sjberman March 11, 2024 23:31
@salonichf5 salonichf5 requested a review from ciarams87 March 11, 2024 23:31
@salonichf5
Copy link
Contributor Author

@lucacome would be great if you could review when time permits

.github/workflows/functional.yml Show resolved Hide resolved
.github/workflows/functional.yml Outdated Show resolved Hide resolved
.github/workflows/functional.yml Outdated Show resolved Hide resolved
@salonichf5 salonichf5 requested a review from lucacome March 12, 2024 19:07
@salonichf5 salonichf5 merged commit ad0242b into main Mar 12, 2024
40 checks passed
@salonichf5 salonichf5 deleted the functional-test branch March 12, 2024 19:28
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this pull request Apr 3, 2024
Problem: As a user, I want to automate functional tests in the pipeline

Solution: To run functional tests in the pipeline, we introduce a new github workflow that sets up the environment to run tests, and upload results

Testing: Manual testing by pushing to the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Automate Functional Tests in the Pipeline
5 participants