Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move version in event handler #1622

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

ciarams87
Copy link
Member

Proposed changes

Problem: The version variable is used by handler to track generated config versions. It is part of the handler config, which means we expect it to be configurable when creating the handler. However, it is not configurable, so should not be part of the config.

Solution: Refactor the handler so that version is part of the handler, not its config

Testing: Ensured all tests still pass successfully and manual verification of the config version file

Closes #1416

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 requested a review from a team as a code owner February 28, 2024 09:27
@github-actions github-actions bot added the bug Something isn't working label Feb 28, 2024
@ciarams87 ciarams87 merged commit be029fa into nginxinc:main Feb 28, 2024
34 checks passed
@ciarams87 ciarams87 deleted the fix/move-version branch February 28, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Refactor config version in the handler type
3 participants