Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installed architecture to telemetry data #1604

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

sjberman
Copy link
Contributor

Problem: As a maintainer of NGF/NIC
I want to record the architecture used (ARM, x86, etc) from all participating NGF installations So that I can ensure used architectures are tested.

Solution: Use the golang runtime library to extract the architecture

Testing: Verified value in logs:

{"level":"debug","ts":"2024-02-21T18:03:03Z","logger":"telemetryExporter","msg":"Exporting telemetry","data":{"ProjectMetadata":{"Name":"NGF","Version":"edge"},"ClusterID":"3b13d5bb-3ccb-4a25-9caf-99d3f9ba89ad","Arch":"arm64","NodeCount":1,"NGFResourceCounts":{"Gateways":1,"GatewayClasses":1,"HTTPRoutes":2,"Secrets":0,"Services":2,"Endpoints":2},"NGFReplicaCount":1}}

Closes #1316

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

NONE

@sjberman sjberman requested a review from a team as a code owner February 21, 2024 18:05
@github-actions github-actions bot added the enhancement New feature or request label Feb 21, 2024
@sjberman sjberman force-pushed the enh/capture-installed-arch branch from 484918e to 1bd8aa5 Compare February 21, 2024 18:07
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Problem: As a maintainer of NGF/NIC
I want to record the architecture used (ARM, x86, etc) from all participating NGF installations
So that I can ensure used architectures are tested.

Solution: Use the golang runtime library to extract the architecture
@sjberman sjberman force-pushed the enh/capture-installed-arch branch from 1bd8aa5 to a7e5000 Compare February 21, 2024 18:35
@sjberman sjberman enabled auto-merge (squash) February 21, 2024 18:36
@sjberman sjberman merged commit 0d1d49a into nginxinc:main Feb 21, 2024
34 checks passed
@sjberman sjberman deleted the enh/capture-installed-arch branch February 21, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Collect Installed Architecture (NGF)
3 participants