-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add docs to install Nginx Gateway Fabric with N+ #1524
Conversation
64f32a2
to
9d89f81
Compare
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
Still a draft, so I'm assuming you're still working on it, but you're missing the actual installation steps. If you look at the example NIC links in the ticket, and scroll down to the installation steps, you'll see there are options for both OSS and Plus. We need a similar structure for all of our installation steps. |
a1b8fdb
to
fd55a6e
Compare
@sjberman Do we not need approval from the documentation team for it? |
@sindhushiv yes, and they are tagged as reviewers on the PR. It's still a draft though, so it's not urgent. |
0724d4c
to
b6978d8
Compare
dbd198f
to
1d65165
Compare
3e52312
to
dd3a922
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving for posterity but have made a humongous amount of edit suggestions.
I can clarify the design changes for each suggestion if desired: I anticipate I will make further changes in the future, but it's beyond the scope of the PR contents.
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
5692cb2
to
60f3032
Compare
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
site/content/installation/ngf-images/jwt-token-docker-secret.md
Outdated
Show resolved
Hide resolved
9de4f09
to
a42e0f5
Compare
a42e0f5
to
8db1ead
Compare
Proposed changes
imagePullSecretName
&imagePullSecretsNames
invalues.yaml
to specify secrets associated with the docker registry to pull and push images to.Information has been updated for installing Nginx Plus with Nginx Gateway Fabric using Helm charts and manifests.
Problem: User should have documentation to install/upgrade Nginx Plus with Nginx Gateway Fabric
Solution: Added documentation specifying multiple ways to install plus with Nginx Gateway Fabric using both helm chart and manifests.
Testing: Lint checks and pipeline builds
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #ISSUE
Checklist
Before creating a PR, run through this checklist and mark each as complete.