Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 1.1 Release #1378

Merged
merged 11 commits into from
Dec 14, 2023
Merged

Prepare 1.1 Release #1378

merged 11 commits into from
Dec 14, 2023

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Update the CHANGELOG and docs in preparation for the 1.1 release.

Note:
There are also some general doc updates that will be copied to the main branch once the release is published.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@kate-osborn kate-osborn requested review from a team as code owners December 13, 2023 20:03
@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Dec 13, 2023
sjberman
sjberman reviewed Dec 13, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
mpstefan
mpstefan requested changes Dec 13, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pleshakov
pleshakov reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should enable docs previews for PRs like this @Jcahilltorre @ADubhlaoich

CHANGELOG.md Outdated Show resolved Hide resolved
ADubhlaoich
ADubhlaoich reviewed Dec 14, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
ADubhlaoich
ADubhlaoich reviewed Dec 14, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
ADubhlaoich
ADubhlaoich approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally, though I have asked two clarifying questions.

They are not blockers, but could lead to confusing user experience.

pleshakov
pleshakov approved these changes Dec 14, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pleshakov
pleshakov reviewed Dec 14, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@kate-osborn kate-osborn requested a review from mpstefan December 14, 2023 18:13
@kate-osborn kate-osborn merged commit 4e3d9c4 into nginx:release-1.1 Dec 14, 2023
23 checks passed
@sjberman sjberman mentioned this pull request Mar 20, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@pleshakov pleshakov pleshakov approved these changes

@bjee19 bjee19 bjee19 approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@mpstefan mpstefan mpstefan approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kate-osborn @pleshakov @ADubhlaoich @mpstefan @sjberman @ciarams87 @bjee19