Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: rewrite resource-validation #1336

Merged
merged 16 commits into from
Dec 12, 2023
Merged

docs: rewrite resource-validation #1336

merged 16 commits into from
Dec 12, 2023

Conversation

Jcahilltorre
Copy link
Contributor

@Jcahilltorre Jcahilltorre commented Dec 5, 2023 •
edited
Loading

Proposed changes

Update the formating and style of the resource validation document.

Testing: Local build of the docs

Update MDLINT config to allow using single asterisk * for italics, not enforcing use of _ underscore

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@Jcahilltorre Jcahilltorre self-assigned this Dec 5, 2023
@Jcahilltorre Jcahilltorre requested a review from a team as a code owner December 5, 2023 14:37
@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for nginx-gateway-fabric canceled.

Name Link
🔨 Latest commit 670492a
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/6578d23ba39aca0009d8cf1e

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 5, 2023
kate-osborn
kate-osborn requested changes Dec 5, 2023
View reviewed changes
site/content/overview/resource-validation.md Outdated Show resolved Hide resolved
site/content/overview/resource-validation.md Outdated Show resolved Hide resolved
site/content/overview/resource-validation.md Outdated Show resolved Hide resolved
@Jcahilltorre Jcahilltorre requested a review from a team as a code owner December 12, 2023 14:02
ADubhlaoich
ADubhlaoich approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jcahilltorre
Copy link
Contributor Author

pushed a commit to fix a broken link with anchors

@kate-osborn kate-osborn merged commit 04522e9 into nginxinc:main Dec 12, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

@sjberman sjberman sjberman approved these changes

Assignees

@ADubhlaoich ADubhlaoich

Labels
documentation Improvements or additions to documentation
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jcahilltorre @ADubhlaoich @sjberman @kate-osborn