Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test utilities for installing NGF #1256

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

sjberman
Copy link
Contributor

Problem:

  1. In order to start running system tests, we need a framework in place.
  2. Sometimes when installed, NGF would start before the control plane CRD existed.

Solution:

  1. Implement a basic framework that installs and uninstalls NGF.
  2. Add a polling loop to find the control plane CRD before exiting.

Testing: Verified no errors in setup and teardown

Closes #985

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Problem:
1. In order to start running system tests, we need a framework in place.
2. Sometimes when installed, NGF would start before the control plane CRD existed.

Solution:

1. Implement a basic framework that installs and uninstalls NGF.
2. Add a polling loop to find the control plane CRD before exiting.
@sjberman sjberman requested a review from a team as a code owner November 16, 2023 22:56
@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation tests Pull requests that update tests labels Nov 16, 2023
tests/framework/ngf.go Show resolved Hide resolved
tests/Makefile Show resolved Hide resolved
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/system_suite_test.go Show resolved Hide resolved
tests/system_suite_test.go Show resolved Hide resolved
tests/system_suite_test.go Show resolved Hide resolved
tests/framework/ngf.go Outdated Show resolved Hide resolved
internal/mode/static/manager.go Outdated Show resolved Hide resolved
internal/mode/static/manager.go Show resolved Hide resolved
@sjberman sjberman requested a review from pleshakov November 17, 2023 21:02
tests/Makefile Outdated Show resolved Hide resolved
@sjberman sjberman merged commit 789b801 into nginxinc:main Nov 20, 2023
21 of 23 checks passed
@sjberman sjberman deleted the tests/ngf-utility branch November 20, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Utility Function for NGF Install
4 participants