-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test plan and results for zero downtime scaling #1174
Merged
kate-osborn
merged 7 commits into
nginxinc:main
from
kate-osborn:tests/zero-downtime-scaling
Nov 1, 2023
Merged
Add test plan and results for zero downtime scaling #1174
kate-osborn
merged 7 commits into
nginxinc:main
from
kate-osborn:tests/zero-downtime-scaling
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
tests
Pull requests that update tests
labels
Oct 20, 2023
pleshakov
reviewed
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable
kate-osborn
force-pushed
the
tests/zero-downtime-scaling
branch
from
October 26, 2023 22:44
29c9ec0
to
64239a6
Compare
kate-osborn
changed the title
Add test plan for zero downtime scaling of NGF
Add test plan and results for zero downtime scaling
Oct 26, 2023
sjberman
reviewed
Oct 31, 2023
pleshakov
reviewed
Oct 31, 2023
kate-osborn
force-pushed
the
tests/zero-downtime-scaling
branch
from
October 31, 2023 22:54
64239a6
to
aff1e71
Compare
bjee19
requested changes
Oct 31, 2023
pleshakov
approved these changes
Nov 1, 2023
sjberman
approved these changes
Nov 1, 2023
Co-authored-by: bjee19 <[email protected]>
Co-authored-by: bjee19 <[email protected]>
kate-osborn
force-pushed
the
tests/zero-downtime-scaling
branch
from
November 1, 2023 19:39
cbe442f
to
992f2c2
Compare
bjee19
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
We don't know if it is possible to scale the number of NGF replicas up and down without downtime.
Solution:
Testing done: Ran through test plan and recorded results.
Closes #1129