Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event processing histogram metric #1134

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: NGF does not measure how long it takes to process an event batch.

Solution: Add a new histogram metric event_batch_processing_milliseconds, that measures the time it takes to process an event batch. Also adds a debug log statement with the same information so we can debug spikes in processing time.

Testing: Tested that the new metric is exported and that no errors occur when metric collection is disabled.

Please focus on (optional): I added a new Prometheus collector that handles this new metric instead of adding this metric to the existing nginx runtime collector. I think it makes sense to keep this metric separate from the nginx runtime metrics in case we end up splitting the control and data planes.

Closes #1131

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@kate-osborn kate-osborn requested a review from a team as a code owner October 11, 2023 23:15
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 11, 2023
@kate-osborn kate-osborn requested a review from a team October 12, 2023 14:06
docs/monitoring.md Outdated Show resolved Hide resolved
internal/mode/static/handler.go Outdated Show resolved Hide resolved
@kate-osborn kate-osborn requested a review from sjberman October 12, 2023 15:35
@kate-osborn kate-osborn force-pushed the feat/batch-processing-metrics branch 2 times, most recently from 8ee4af2 to 2f8d042 Compare October 12, 2023 17:51
@kate-osborn kate-osborn force-pushed the feat/batch-processing-metrics branch from 2f8d042 to 6288b83 Compare October 12, 2023 17:58
@kate-osborn kate-osborn requested a review from pleshakov October 12, 2023 18:03
@kate-osborn kate-osborn merged commit 567f27e into nginxinc:main Oct 12, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add metric and log for batch processing time
5 participants