Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zero downtime upgrade test plan and results #1120

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Add zero downtime upgrade test plan and results #1120

merged 7 commits into from
Oct 16, 2023

Conversation

pleshakov
Copy link
Contributor

@pleshakov pleshakov commented Oct 9, 2023 •
edited
Loading

Proposed changes

Problem:

  • We don't know if it is possible to upgrade NGF from a previous version without downtime.

Solution:

  • Prepare a test plan to test for zero-downtime upgrades of NGF.
  • Test NFG and share the results

SOLVES -- #950

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 9, 2023
sjberman
sjberman reviewed Oct 10, 2023
View reviewed changes
tests/zero-downtime-upgrades/README.md Outdated Show resolved Hide resolved
tests/zero-downtime-upgrades/README.md Outdated Show resolved Hide resolved
@pleshakov
Add zero downtime upgrade test plan and results
b46f54f 
Problem:
- We don't know if it is possible to upgrade NGF from a previous
version without downtime.

Solution:
- Prepare a test plan to test for zero-downtime upgrades of NGF.
- Test NFG and share the results (TO-DO).

SOLVES -- nginxinc#950
@pleshakov
Update the draft plan and add test results
7121d7f
@pleshakov pleshakov marked this pull request as ready for review October 13, 2023 23:41
@pleshakov pleshakov requested a review from a team as a code owner October 13, 2023 23:41
kate-osborn
kate-osborn approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

tests/zero-downtime-upgrades/zero-downtime-upgrades.md Outdated Show resolved Hide resolved
@pleshakov pleshakov mentioned this pull request Oct 16, 2023
Closed
@pleshakov pleshakov requested a review from sjberman October 16, 2023 17:28
@pleshakov pleshakov merged commit 6e1c9d8 into nginxinc:main Oct 16, 2023
22 checks passed
@pleshakov pleshakov deleted the test/zero-downtime branch October 16, 2023 23:13
@ciarams87 ciarams87 added the tests Pull requests that update tests label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianehlert brianehlert brianehlert left review comments

@bjee19 bjee19 bjee19 approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@sjberman sjberman sjberman approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pleshakov @brianehlert @sjberman @ciarams87 @kate-osborn @bjee19