Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconfig tests setup and results #1116

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

ciarams87
Copy link
Member

Proposed changes

Problem: We need a baseline for ensuring the control plane is able to process X number of resources in Y time and apply the configuration to the data plane

Solution: Run manual testing to capture reconfiguration performance of NFG

Closes #952

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 9, 2023
@ciarams87 ciarams87 force-pushed the tests/reconfiguration branch from 3bd981d to 8ba540d Compare October 9, 2023 09:59
tests/reconfig/results/v1.0.0.md Outdated Show resolved Hide resolved
tests/reconfig/setup.md Outdated Show resolved Hide resolved
tests/reconfig/setup.md Outdated Show resolved Hide resolved
tests/reconfig/setup.md Outdated Show resolved Hide resolved
tests/reconfig/setup.md Outdated Show resolved Hide resolved
tests/reconfig/results/v1.0.0.md Outdated Show resolved Hide resolved
tests/reconfig/results/v1.0.0.md Show resolved Hide resolved
tests/reconfig/setup.md Show resolved Hide resolved
tests/reconfig/results/v1.0.0.md Outdated Show resolved Hide resolved
tests/reconfig/setup.md Outdated Show resolved Hide resolved
tests/reconfig/setup.md Outdated Show resolved Hide resolved
tests/reconfig/setup.md Outdated Show resolved Hide resolved
tests/reconfig/setup.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ciarams87 ciarams87 marked this pull request as ready for review October 11, 2023 08:11
@ciarams87 ciarams87 requested a review from a team as a code owner October 11, 2023 08:11
@ciarams87 ciarams87 force-pushed the tests/reconfiguration branch from c1ed3e9 to 44bf945 Compare October 11, 2023 08:11
@ciarams87 ciarams87 merged commit 704f8a8 into nginxinc:main Oct 11, 2023
22 checks passed
@ciarams87 ciarams87 deleted the tests/reconfiguration branch October 11, 2023 08:38
@ciarams87 ciarams87 added the tests Pull requests that update tests label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Baseline Testing: Reconfiguration performance
4 participants