Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run helm tests on tag event #1027

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

ciarams87
Copy link
Member

Proposed changes

Problem: The Helm publish step isn't running on tags because helm tests are a requirement for the publish step, and we are not currently running the tests when the ref type is a tag

Solution: Run the helm tests for tags

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner September 1, 2023 11:07
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 1, 2023
@ciarams87 ciarams87 force-pushed the chore/fix-helm-publish branch from 02178d0 to 85cc018 Compare September 1, 2023 15:30
@ciarams87 ciarams87 merged commit f540fca into nginxinc:main Sep 1, 2023
22 checks passed
@ciarams87 ciarams87 deleted the chore/fix-helm-publish branch September 1, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants