Add workflow for updating nginx base image #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarams87
force-pushed
the
chore/update-nginx-docker
branch
from
954e22a to
e3c256b
Compare
sjberman
reviewed
Sep 1, 2023
ciarams87
force-pushed
the
chore/update-nginx-docker
branch
from
e3c256b to
d79e1fa
Compare
sjberman
approved these changes
Sep 1, 2023
ciarams87
force-pushed
the
chore/update-nginx-docker
branch
from
d79e1fa to
1f499f2
Compare
ciarams87
force-pushed
the
chore/update-nginx-docker
branch
from
1f499f2 to
4b7c616
Compare
kate-osborn
approved these changes
Sep 6, 2023
bjee19
approved these changes
Sep 8, 2023
ciarams87
force-pushed
the
chore/update-nginx-docker
branch
from
4b7c616 to
da5eac5
Compare
ciarams87
force-pushed
the
chore/update-nginx-docker
branch
from
da5eac5 to
8e05063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As a user of NKG
I want the data plane image to be automatically updated when the nginx image is updated
So that the data plane for NKG always includes the most up to date image for a given version of nginx.
NOTE: This does not update the image version itself, but rather the underlying base image (e.g. to include patched libraries)
Closes #904
Checklist
Before creating a PR, run through this checklist and mark each as complete.