Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Gomega matcher library for assertions in unit tests #823

Closed
pleshakov opened this issue Jul 6, 2023 · 0 comments · Fixed by #1046
Closed

Use Gomega matcher library for assertions in unit tests #823

pleshakov opened this issue Jul 6, 2023 · 0 comments · Fixed by #1046
Assignees
@bjee19
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses. good first issue Good for newcomers tech-debt Short-term pain, long-term benefit

Comments

@pleshakov
Copy link
Contributor

For assertions in unit tests, we started using Gomega matcher library. This is also reflected in https://github.com/nginxinc/nginx-kubernetes-gateway/blob/main/docs/developer/testing.md#unit-test-guidelines
However, we haven't updated all existing tests yet

Acceptance criteria:

  • Update all unit tests to use gomega matcher in assertions
@pleshakov pleshakov added the enhancement New feature or request label Jul 6, 2023
@pleshakov pleshakov added tech-debt Short-term pain, long-term benefit and removed enhancement New feature or request labels Jul 6, 2023
@mpstefan mpstefan added the good first issue Good for newcomers label Jul 12, 2023
@mpstefan mpstefan modified the milestone: v1.1.0 Jul 12, 2023
@mpstefan mpstefan added the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Jul 13, 2023
@bjee19 bjee19 self-assigned this Sep 6, 2023
@bjee19 bjee19 moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Sep 6, 2023
@bjee19 bjee19 mentioned this issue Sep 8, 2023
Merged
6 tasks
@bjee19 bjee19 moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Sep 8, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjee19 bjee19

Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses. good first issue Good for newcomers tech-debt Short-term pain, long-term benefit
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace unit test assertions with Gomega matchers bjee19/nginx-gateway-fabric
3 participants
@pleshakov @mpstefan @bjee19