Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated upstreams are missing upstream zone size #482

Closed
kate-osborn opened this issue Mar 17, 2023 · 5 comments · Fixed by #609
Closed

Generated upstreams are missing upstream zone size #482

kate-osborn opened this issue Mar 17, 2023 · 5 comments · Fixed by #609
Assignees
@kate-osborn
Labels
area/nginx-configuration Relates to nginx configuration bug Something isn't working
Milestone
v0.4.0

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented Mar 17, 2023 •
edited
Loading

A/C:
@kate-osborn kate-osborn added bug Something isn't working area/nginx-configuration Relates to nginx configuration labels Mar 17, 2023
@kate-osborn kate-osborn modified the milestones: v1.0.0, v0.4.0 Mar 21, 2023
@kate-osborn
Copy link
Contributor Author

@pleshakov what's a good default zone size? 256k?

@brianehlert
Copy link

@pleshakov what's a good default zone size? 256k?

I believe that NIC is now 512 to handle additional N+ metrics if you want to forward proof.

@pleshakov
Copy link
Contributor

@kate-osborn I suggest trying to experiment -- see which value will fail for X number of upstream servers during reload. If it is still not clear, better to ask on NGINX community channels.

@jasonwilliams14
Copy link

@pleshakov @brianehlert @kate-osborn
Hopefully this is helpful. Accounts for the extra added HTTP codes R25 added.

nginxinc/kubernetes-ingress#2009

@kate-osborn kate-osborn self-assigned this May 3, 2023
@kate-osborn kate-osborn moved this from 🆕 New to 🔖 To Do in NGINX Gateway Fabric May 3, 2023
@kate-osborn kate-osborn moved this from 🔖 To Do to 🏗 In Progress in NGINX Gateway Fabric May 3, 2023
@kate-osborn
Copy link
Contributor Author

Upstream zone size testing on Nginx 1.23

Zone Size Max Upstream Servers
256k 312
512k 648
1m 1311

I think 512k is a reasonable default. Thoughts @pleshakov @brianehlert @jasonwilliams14?

@kate-osborn kate-osborn mentioned this issue May 3, 2023
Merged
@kate-osborn kate-osborn moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric May 3, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kate-osborn kate-osborn

Labels
area/nginx-configuration Relates to nginx configuration bug Something isn't working
Projects
NGINX Gateway Fabric
Archived in project
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

Set upstream zone size to 512k nginxinc/nginx-gateway-fabric
4 participants
@pleshakov @brianehlert @jasonwilliams14 @kate-osborn