Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a common k8s API fake reader #1573

Open
pleshakov opened this issue Feb 13, 2024 · 1 comment
Open

Use a common k8s API fake reader #1573

pleshakov opened this issue Feb 13, 2024 · 1 comment
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses. good first issue Good for newcomers tech-debt Short-term pain, long-term benefit

Comments

@pleshakov
Copy link
Contributor

#1551 telemetry package starting using

nginx-gateway-fabric/internal/framework/events/eventsfakes/fake_reader.go

Line 13 in dca4d64

type FakeReader struct {
which is generated in

nginx-gateway-fabric/internal/framework/events/first_eventbatch_preparer.go

Line 28 in dca4d64

type Reader interface {
, which creates unnecessary dependency between modules

Acceptance criteria:

  • Remove that unnecessary dependency

Came from #1551 (comment)
@pleshakov pleshakov mentioned this issue Feb 13, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Feb 28, 2024
@sjberman sjberman added the tech-debt Short-term pain, long-term benefit label Feb 28, 2024
@github-actions github-actions bot removed the stale Pull requests/issues with no activity label Feb 29, 2024
@mpstefan mpstefan changed the title Use a commom k8s API fake reader Use a common k8s API fake reader Mar 11, 2024
@mpstefan mpstefan added good first issue Good for newcomers backlog Currently unprioritized work. May change with user feedback or as the product progresses. labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses. good first issue Good for newcomers tech-debt Short-term pain, long-term benefit
Projects
NGINX Gateway Fabric
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pleshakov @mpstefan @sjberman