Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect Image Source (NGF) #1310

Closed
mpstefan opened this issue Dec 1, 2023 · 2 comments · Fixed by #1600
Closed

Collect Image Source (NGF) #1310

mpstefan opened this issue Dec 1, 2023 · 2 comments · Fixed by #1600
Assignees
@ciarams87
Labels
area/telemetry Issues related to collected telemetry data refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Milestone
v1.2.0

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Dec 1, 2023 •
edited
Loading

As a maintainer of NGF
I want to collect the image source from all NGF/NIC installations
So that I can understand the most popular methods for installing NGF/NIC

Acceptance

  • The repository location of the image is NOT recorded.
  • A method internal to the image is used to identify if the image is custom or pulled directly.
@mpstefan mpstefan mentioned this issue Dec 1, 2023
Closed
@mpstefan mpstefan added the area/telemetry Issues related to collected telemetry data label Dec 1, 2023
@mpstefan mpstefan added this to the v1.2.0 milestone Dec 1, 2023
@mpstefan mpstefan changed the title Record Image Source Collect Image Source (NGF) Dec 13, 2023
@mpstefan
Copy link
Collaborator Author

When we build, we may be able to inject a tag in our build pipeline via build arguments so that pre-built images are marked.

@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days labels Dec 15, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Feb 6, 2024
@sjberman sjberman removed the stale Pull requests/issues with no activity label Feb 6, 2024
@ciarams87 ciarams87 self-assigned this Feb 21, 2024
@ciarams87 ciarams87 mentioned this issue Feb 21, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciarams87 ciarams87

Labels
area/telemetry Issues related to collected telemetry data refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Add image source to telemetry data ciarams87/nginx-gateway-fabric
3 participants
@mpstefan @sjberman @ciarams87