Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clients experience downtime during NGF upgrade #1143

Closed
pleshakov opened this issue Oct 16, 2023 · 4 comments
Closed

Clients experience downtime during NGF upgrade #1143

pleshakov opened this issue Oct 16, 2023 · 4 comments

Comments

@pleshakov
Copy link
Contributor

pleshakov commented Oct 16, 2023

Describe the bug
During an upgrade of NGF, external clients can experience downtime.

To Reproduce

See the test setup and steps published in #1120

As a result, during upgrade client HTTP and HTTPs traffic got affected:

note: time scale is MM:SS

HTTP:
http

HTTPS:
https

Expected behavior

External clients don't experience downtime during an upgrade of NGF.

Your environment

Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.3-gke.100", GitCommit:"6466b51b762a5c49ae3fb6c2c7233ffe1c96e48c", GitTreeState:"clean", BuildDate:"2023-06-23T09:27:28Z", GoVersion:"go1.20.5 X:boringcrypto", Compiler:"gc", Platform:"linux/amd64"}

Old NGF version:

"version":"0.6.0"
"commit":"803e6d612a9574362bda28868d4410943ffaf66a"
"date":"2023-08-31T16:32:37Z"

New NGF version:

version: "edge"
commit: "5324908e6e1145bec5f2f0ab80b312a809ad1744"
date: "2023-10-13T18:29:23Z"

Additional context
See #1120

@kate-osborn
Copy link
Contributor

@pleshakov can you describe the bug more in this ticket? I'm not sure which result you are pointing to in the linked PR.

@brianehlert
Copy link

I am also assuming multiple gateway replicas and a rolling upgrade in the deployment design.

@mpstefan
Copy link
Collaborator

Should be addressed by solving #1154 and #1155

@mpstefan
Copy link
Collaborator

Fixed thanks to the above issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants