Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry on status update failures #1016

Closed
Tracked by #691
mpstefan opened this issue Aug 30, 2023 · 0 comments · Fixed by #1062
Closed
Tracked by #691

Retry on status update failures #1016

mpstefan opened this issue Aug 30, 2023 · 0 comments · Fixed by #1062
Assignees
@bjee19
Labels
enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Milestone
v1.0.0

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Aug 30, 2023 •
edited
Loading

As a user of NKG
I want NKG to retry on status update failures
So that transient issues within Kubernetes do not prevent NKG from updating the status on its resources and leading me down a wrong debugging path when something goes wrong.

Acceptance

-When NKG fails to update status on a Kubernetes resource, it will retry if a relevant error is returned

  • A small back off is implemented for each retry
  • When the NKG pod context is cancelled, the status updater component will gracefully exit.

Original Issue:
It doesn't retry on failures. This means there is a chance that some resources will not have up-to-do statuses.
Statuses are important part of the Gateway API, so we need to ensure that the Gateway always keep the resources
statuses up-to-date.
@mpstefan mpstefan mentioned this issue Aug 30, 2023
Closed
@mpstefan mpstefan added this to the v1.0.0 milestone Sep 6, 2023
@mpstefan mpstefan added enhancement New feature or request size/small Estimated to be completed within ~2 days refined Requirements are refined and the issue is ready to be implemented. labels Sep 6, 2023
@mpstefan mpstefan mentioned this issue Sep 6, 2023
Closed
@bjee19 bjee19 moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Sep 11, 2023
@bjee19 bjee19 mentioned this issue Sep 15, 2023
Merged
6 tasks
@bjee19 bjee19 moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Sep 15, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjee19 bjee19

Labels
enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Projects
NGINX Gateway Fabric
Archived in project
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Implement Status Updater Retrying on Failures bjee19/nginx-gateway-fabric
2 participants
@mpstefan @bjee19