[Helm charts] Add support to set resources for controller pods #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
Dean-Coakley
suggested changes
Jul 25, 2019
There was a problem hiding this comment.
Thanks so much for taking the time to open this pull request!
This looks great!
The most important change that needs to be done is to add an entry for controller.resources into our docs. https://github.com/nginxinc/kubernetes-ingress/blob/master/deployments/helm-chart/README.md#configuration
I've made a few small change requests too, to ensure consistency.
guilhermeoki
force-pushed
the
feature/support-set-resources
branch
from
70519d3 to
4496d18
Compare
Dean-Coakley
suggested changes
Jul 26, 2019
guilhermeoki
force-pushed
the
feature/support-set-resources
branch
from
4496d18 to
355a7ec
Compare
Dean-Coakley
approved these changes
Jul 30, 2019
|
Thanks a lot! @guilhermeoki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add support to set resources for controller pods in helm charts.
Checklist
Before creating a PR, run through this checklist and mark each as complete.