Use Controller name value for app selectors #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
After upgrading Helm charts to the ones in version 1.5.0 of the Ingress Controller, there was a problem with old rs/pods not being removed correctly.
With this fix, it is possible to use the
controller.nameto make sure the app selector in deployment/daemonset/service is the same and K8s will update them instead of create new ones.Note: If using a
deployment, the old replicaset will still be there after the update, however, it will have 0 pods. The reason behind it is that the Deployment who is the replicaset owner is still alive, although using a new label. It is safe to remove that replicaset as it doesn't have any pods.