Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ingress Controller Prometheus metrics #554

Merged
merged 1 commit into from
May 2, 2019
Merged

Add Ingress Controller Prometheus metrics #554

merged 1 commit into from
May 2, 2019

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented May 1, 2019

Proposed changes

This PR introduces a new set of metrics in the Prometheus format for the Ingress Controller.

Fixes #283

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Rulox Rulox requested a review from pleshakov May 1, 2019 10:27
@Rulox Rulox self-assigned this May 1, 2019
pleshakov
pleshakov approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
There is one small thing, if you could address that before merging.

docs/prometheus.md Outdated Show resolved Hide resolved
@pleshakov pleshakov added enhancement Pull requests for new features/feature enhancements change Pull requests that introduce a change labels May 1, 2019
@pleshakov
Copy link
Contributor

@Rulox I added the label "change" because the PR changes the namespace for NGINX/NGINX Plus metrics.

@Rulox
Copy link
Contributor Author

Rulox commented May 2, 2019

Waiting for CI to pass before merging

@Rulox Rulox merged commit 12d4205 into master May 2, 2019
@Rulox Rulox deleted the ic-metrics branch May 2, 2019 10:57
@MaxMood96 MaxMood96 mentioned this pull request Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

Assignees

@Rulox Rulox

Labels
change Pull requests that introduce a change enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does the ingress-controller binary expose metrics?
2 participants
@Rulox @pleshakov