Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OIDC policy #1304

Merged
merged 11 commits into from
Jan 15, 2021
Merged

Add OIDC policy #1304

merged 11 commits into from
Jan 15, 2021

Conversation

lucacome
Copy link
Member

Add OIDC policy

TODO:

  • docs

@lucacome lucacome self-assigned this Jan 14, 2021
mikestephen
mikestephen approved these changes Jan 14, 2021
View reviewed changes
Copy link

@mikestephen mikestephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me Luca!

LorcanMcVeigh
LorcanMcVeigh approved these changes Jan 14, 2021
View reviewed changes
internal/configs/virtualserver.go Outdated Show resolved Hide resolved
Dean-Coakley
Dean-Coakley approved these changes Jan 14, 2021
View reviewed changes
internal/configs/configurator.go Outdated Show resolved Hide resolved
pleshakov
pleshakov reviewed Jan 14, 2021
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lucacome
Please see my feedback.
I will provide feedback about the example shortly

internal/configs/virtualserver.go Outdated Show resolved Hide resolved
internal/configs/virtualserver.go
@@ -823,6 +854,84 @@ func (p *policiesCfg) addEgressMTLSConfig(
return res
}

func (p *policiesCfg) addOIDCConfig(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add more test cases for addOIDCConfig ? from looking at the coverage, there are no cases for the edge cases

internal/k8s/controller.go Show resolved Hide resolved
internal/k8s/secrets/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/policy_test.go Outdated Show resolved Hide resolved
@pleshakov
Copy link
Contributor

@lucacome
didn't catch it right away. after running the example, I noticed the findPoliciesForSecret in internal/k8s/controller.go:2483 doesn't support oidc secret. This means updating the secret doesn't update it in the config

pleshakov
pleshakov approved these changes Jan 15, 2021
View reviewed changes
internal/k8s/controller.go Show resolved Hide resolved
internal/configs/virtualserver_test.go Outdated Show resolved Hide resolved
examples-of-custom-resources/oidc/oidc.yaml Outdated Show resolved Hide resolved
@lucacome lucacome merged commit 5b0b177 into master Jan 15, 2021
@lucacome lucacome deleted the oidc-js branch January 15, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@mikestephen mikestephen mikestephen approved these changes

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees

@lucacome lucacome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucacome @pleshakov @mikestephen @Dean-Coakley @LorcanMcVeigh