Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nginx-health path to be configurable #721

Closed
warmfusion opened this issue Oct 10, 2019 · 2 comments · Fixed by #750
Closed

Allow nginx-health path to be configurable #721

warmfusion opened this issue Oct 10, 2019 · 2 comments · Fixed by #750
Labels
proposal An issue that proposes a feature request

Comments

@warmfusion
Copy link

Is your feature request related to a problem? Please describe.
as per #90 a healthcheck endpoint can be requested on the controller, however the path is hardcoded as /nginx-health. This means that in an environment using multiple ingress controllers or different balancers any monitoring systems have to have different paths for different endpoints.

Describe the solution you'd like
I'd like to be able to specify the health-check path through annotation (as suggested on #90) so that I can choose my own endpoint and make it consistent across our ecosystem of different balancer tools.

Describe alternatives you've considered

  • Patching the code directly and forking my own ingress controller
  • Switching to a totally different ingress controller
  • Forcing all my other (non-nginx) balancers to use the nginx-health as a status path
@Rulox Rulox added the proposal An issue that proposes a feature request label Oct 10, 2019
@Rulox
Copy link
Contributor

Rulox commented Oct 10, 2019

Hi @warmfusion thanks for the proposal.

That's actually a valid use case, we'll discuss this internally and will get back to you with a response as soon as possible.

Thanks!

@pleshakov
Copy link
Contributor

@warmfusion
thanks for the proposal. it makes sense to be able to customize the health check path.

In the meantime, as a workaround, you can use a custom template with the location for the health check changed to the required one:

        {{if .HealthStatus}}
        location /standard-health-endpoint {
            default_type text/plain;
            return 200 "healthy\n";
        }
        {{end}}

Please see custom templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal An issue that proposes a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants