From 2be8de7dbab9882580980237cef167a069d8297c Mon Sep 17 00:00:00 2001
From: Paul Abel
Date: Wed, 25 Sep 2024 16:36:30 +0100
Subject: [PATCH] prevent final result from succeeding if any image builds fail
---
.github/workflows/ci.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 8e7a70f48c..5b3492dfe6 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -648,7 +648,7 @@ jobs:
tag-stable:
name: Tag tested image as stable
- needs: [checks, smoke-tests-oss, smoke-tests-plus, smoke-tests-nap]
+ needs: [checks, build-docker, build-docker-plus, build-docker-nap, smoke-tests-oss, smoke-tests-plus, smoke-tests-nap]
permissions:
contents: read # To checkout repository
id-token: write # To sign into Google Container Registry
@@ -664,7 +664,7 @@ jobs:
if: ${{ !cancelled() }}
runs-on: ubuntu-24.04
name: Final CI Results
- needs: [tag-stable, smoke-tests-oss, smoke-tests-plus, smoke-tests-nap]
+ needs: [tag-stable, build-docker, build-docker-plus, build-docker-nap, smoke-tests-oss, smoke-tests-plus, smoke-tests-nap]
steps:
- run: |
tagResult="${{ needs.tag-stable.result }}"