From 4abb36ea21446195ba30b2d851368dcc48cd5e37 Mon Sep 17 00:00:00 2001 From: shaun-nx Date: Wed, 23 Aug 2023 12:24:10 +0100 Subject: [PATCH 1/3] Update example spec comment for GlobalConfiguration in helm values.yaml --- deployments/helm-chart/values.yaml | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/deployments/helm-chart/values.yaml b/deployments/helm-chart/values.yaml index 531af909af..0116a56763 100644 --- a/deployments/helm-chart/values.yaml +++ b/deployments/helm-chart/values.yaml @@ -271,14 +271,20 @@ controller: create: false ## The spec of the GlobalConfiguration for defining the global configuration parameters of the Ingress Controller. - spec: {} - # listeners: - # - name: dns-udp - # port: 5353 - # protocol: UDP - # - name: dns-tcp - # port: 5353 - # protocol: TCP + spec: { +# "listeners": [ +# { +# "name": "dns-udp", +# "port": 5353, +# "protocol": "UDP" +# }, +# { +# "name": "dns-tcp", +# "port": 5353, +# "protocol": "TCP" +# } +# ] + } ## Enable custom NGINX configuration snippets in Ingress, VirtualServer, VirtualServerRoute and TransportServer resources. enableSnippets: false From a7054ce4c044cd86ce0eafbe29c78cef3459644e Mon Sep 17 00:00:00 2001 From: shaun-nx Date: Wed, 23 Aug 2023 12:35:01 +0100 Subject: [PATCH 2/3] Fir comment indentation --- deployments/helm-chart/values.yaml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/deployments/helm-chart/values.yaml b/deployments/helm-chart/values.yaml index 0116a56763..9b5d2ab1db 100644 --- a/deployments/helm-chart/values.yaml +++ b/deployments/helm-chart/values.yaml @@ -272,18 +272,18 @@ controller: ## The spec of the GlobalConfiguration for defining the global configuration parameters of the Ingress Controller. spec: { -# "listeners": [ -# { -# "name": "dns-udp", -# "port": 5353, -# "protocol": "UDP" -# }, -# { -# "name": "dns-tcp", -# "port": 5353, -# "protocol": "TCP" -# } -# ] + # "listeners": [ + # { + # "name": "dns-udp", + # "port": 5353, + # "protocol": "UDP" + # }, + # { + # "name": "dns-tcp", + # "port": 5353, + # "protocol": "TCP" + # } + # ] } ## Enable custom NGINX configuration snippets in Ingress, VirtualServer, VirtualServerRoute and TransportServer resources. From 61883cc80e961a209e844fb4058cd9fcba2cc5eb Mon Sep 17 00:00:00 2001 From: shaun-nx Date: Thu, 24 Aug 2023 10:23:58 +0100 Subject: [PATCH 3/3] Inform users to remove curly brackets when using YAML notation --- deployments/helm-chart/values.yaml | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/deployments/helm-chart/values.yaml b/deployments/helm-chart/values.yaml index 9b5d2ab1db..62fe88e0fd 100644 --- a/deployments/helm-chart/values.yaml +++ b/deployments/helm-chart/values.yaml @@ -271,20 +271,15 @@ controller: create: false ## The spec of the GlobalConfiguration for defining the global configuration parameters of the Ingress Controller. - spec: { - # "listeners": [ - # { - # "name": "dns-udp", - # "port": 5353, - # "protocol": "UDP" - # }, - # { - # "name": "dns-tcp", - # "port": 5353, - # "protocol": "TCP" - # } - # ] - } + spec: {} ## Ensure both curly brackets are removed when adding listeners in YAML format. + # listeners: + # - name: dns-udp + # port: 5353 + # protocol: UDP + # - name: dns-tcp + # port: 5353 + # protocol: TCP + ## Enable custom NGINX configuration snippets in Ingress, VirtualServer, VirtualServerRoute and TransportServer resources. enableSnippets: false