From ad8decd13eac2fc85e945c537277bfe73bce04cc Mon Sep 17 00:00:00 2001 From: Venktesh Date: Mon, 26 Sep 2022 15:50:30 +0100 Subject: [PATCH 1/2] Change AppProtect warning message --- tests/suite/test_app_protect_integration.py | 4 ++-- tests/suite/test_app_protect_waf_policies.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/suite/test_app_protect_integration.py b/tests/suite/test_app_protect_integration.py index 3fbab531dc..5e4d5061f4 100644 --- a/tests/suite/test_app_protect_integration.py +++ b/tests/suite/test_app_protect_integration.py @@ -390,14 +390,14 @@ def test_ap_multi_sec_logs( assert_invalid_responses(response) # check logs in dest. #1 i.e. syslog server #1 assert ( - 'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS)"' in log_contents + 'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS),Other Application Activity"' in log_contents and 'severity="Critical"' in log_contents and 'request_status="blocked"' in log_contents and 'outcome="REJECTED"' in log_contents ) # check logs in dest. #2 i.e. syslog server #2 assert ( - 'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS)"' in log2_contents + 'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS),Other Application Activity"' in log2_contents and 'severity="Critical"' in log2_contents and 'request_status="blocked"' in log2_contents and 'outcome="REJECTED"' in log2_contents diff --git a/tests/suite/test_app_protect_waf_policies.py b/tests/suite/test_app_protect_waf_policies.py index cac1454607..7a4199c75c 100644 --- a/tests/suite/test_app_protect_waf_policies.py +++ b/tests/suite/test_app_protect_waf_policies.py @@ -367,7 +367,7 @@ def test_ap_waf_policy_multi_logs( assert_invalid_responses(response) - assert f'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS)"' in log_contents + assert f'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS),Other Application Activity"' in log_contents assert f'severity="Critical"' in log_contents assert f'request_status="blocked"' in log_contents assert f'outcome="REJECTED"' in log_contents From ee26e536d9e53e05506d17b76330ceef5d869f47 Mon Sep 17 00:00:00 2001 From: Venktesh Date: Mon, 26 Sep 2022 15:53:32 +0100 Subject: [PATCH 2/2] run linter --- tests/suite/test_app_protect_integration.py | 6 ++++-- tests/suite/test_app_protect_waf_policies.py | 5 ++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/suite/test_app_protect_integration.py b/tests/suite/test_app_protect_integration.py index 5e4d5061f4..c76a415fde 100644 --- a/tests/suite/test_app_protect_integration.py +++ b/tests/suite/test_app_protect_integration.py @@ -390,14 +390,16 @@ def test_ap_multi_sec_logs( assert_invalid_responses(response) # check logs in dest. #1 i.e. syslog server #1 assert ( - 'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS),Other Application Activity"' in log_contents + 'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS),Other Application Activity"' + in log_contents and 'severity="Critical"' in log_contents and 'request_status="blocked"' in log_contents and 'outcome="REJECTED"' in log_contents ) # check logs in dest. #2 i.e. syslog server #2 assert ( - 'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS),Other Application Activity"' in log2_contents + 'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS),Other Application Activity"' + in log2_contents and 'severity="Critical"' in log2_contents and 'request_status="blocked"' in log2_contents and 'outcome="REJECTED"' in log2_contents diff --git a/tests/suite/test_app_protect_waf_policies.py b/tests/suite/test_app_protect_waf_policies.py index 7a4199c75c..1f34c76cfa 100644 --- a/tests/suite/test_app_protect_waf_policies.py +++ b/tests/suite/test_app_protect_waf_policies.py @@ -367,7 +367,10 @@ def test_ap_waf_policy_multi_logs( assert_invalid_responses(response) - assert f'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS),Other Application Activity"' in log_contents + assert ( + f'ASM:attack_type="Non-browser Client,Abuse of Functionality,Cross Site Scripting (XSS),Other Application Activity"' + in log_contents + ) assert f'severity="Critical"' in log_contents assert f'request_status="blocked"' in log_contents assert f'outcome="REJECTED"' in log_contents