Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for k8s 1.18 Ingress Class? #924

Closed
TheSithPadawan opened this issue Apr 17, 2020 · 4 comments · Fixed by #1133
Closed

Support for k8s 1.18 Ingress Class? #924

TheSithPadawan opened this issue Apr 17, 2020 · 4 comments · Fixed by #1133

Comments

@TheSithPadawan
Copy link

How will nginx support the Ingress Class for the new k8s update?

apiVersion: "networking.k8s.io/v1beta1"
kind: "IngressClass"
metadata:
  name: "external-lb"
spec:
  controller: "example.com/ingress-controller" --> how should we specify nginx ingress controller?
  parameters: --> what parameters are needed?
    apiGroup: "k8s.example.com/v1alpha"
    kind: "IngressParameters"
    name: "external-lb"

Thank you!

@pleshakov
Copy link
Contributor

Hi @TheSithPadawan

Our Ingress Controller doesn’t support yet the IngressClass Resource and the new ingressClassName field of the Ingress resource.

We haven’t decided yet how we’re going to support the IngressClass resource.

@TheSithPadawan
Copy link
Author

Thanks for the update! Any ETA for when you will support the IngressClass resource?

@pleshakov
Copy link
Contributor

@TheSithPadawan we don't have an ETA now. However, I will update this issue once we have it.

Since (1) this is a very recent feature and supported only in k8s 1.18+ and (2) the old way with the class annotation will continue to work (although it is deprecated) , I wonder if there are any reasons you're asking for this feature?

@TheSithPadawan
Copy link
Author

@pleshakov I'm working on a networking controller for k8s, and we want to support nginx controller, so just want to see what's your design/expectation for the new updates. Plz keep me posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants