-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch for secret after ingress creation #78
Comments
Yep, watching for Secrets is not implemented. The controller must have it. Let me know if you're interested in implementing it. |
@pleshakov Setting up another listener or retry process is much more difficult and more error prone, without good test coverage. |
@thetechnick Yep, the current behavior of proceeding with an Ingress with TSL but with a missing Secret must not be allowed. Let me know what particular parts you think should be covered with tests. |
@pleshakov |
The nginx ingress controller will ignore the TLS configuration of ingress objects, if the specified secret does not yet exist. If the secret is created afterwards, the nginx ingress controller does not update the rendered ingress configuration and the ingress will still be served without TLS.
I would expect the nginx ingress controller to wait for the secret to be created, or at least to update the generated configuration.
This feature, aside from #76, would be needed to support https://github.com/jetstack/kube-lego
The text was updated successfully, but these errors were encountered: