Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sizeLimit to emptyDir configuration #7053

Open
atombrella opened this issue Jan 3, 2025 · 2 comments
Open

Add sizeLimit to emptyDir configuration #7053

atombrella opened this issue Jan 3, 2025 · 2 comments
Labels
proposal An issue that proposes a feature request ready for refinement An issue that was triaged and it is ready to be refined

Comments

@atombrella
Copy link

Is your feature request related to a problem? Please describe.

https://github.com/nginxinc/kubernetes-ingress/blob/93eec0dc5998872a2ac8552ec5034a6f96c5bcde/charts/nginx-ingress/templates/_helpers.tpl#L352

I think it'd be nice if these emptyDir had a sizeLimit (maybe configurable). It's supported since Kubernetes 1.22

https://kubernetes.io/docs/concepts/storage/volumes/?emptydir#emptydir

{{- if eq (include "nginx-ingress.readOnlyRootFilesystem" .) "true" }}
- name: nginx-etc
  emptyDir: {}
- name: nginx-cache
  emptyDir: {}
- name: nginx-lib
  emptyDir: {}
- name: nginx-log
  emptyDir: {}
{{- end }}

Describe the solution you'd like

Either maybe some sane defaults. One volume is used for configuration files that shouldn't take up much space (10Mb seems like a good value). For the others, I'm not sure what would be good.

Describe alternatives you've considered

I don't like to edit anything else than value-files from the Helm chart.

@atombrella atombrella added the proposal An issue that proposes a feature request label Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Hi @atombrella thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@pdabelf5 pdabelf5 added needs triage An issue that needs to be triaged ready for refinement An issue that was triaged and it is ready to be refined and removed needs triage An issue that needs to be triaged labels Jan 13, 2025
@pdabelf5
Copy link
Collaborator

@atombrella can you please expand on the reasons for this? Is there anything beyond what is described here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal An issue that proposes a feature request ready for refinement An issue that was triaged and it is ready to be refined
Projects
Status: Todo ☑
Development

No branches or pull requests

2 participants