Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding pod spec annotations to nginx plus daemonset/deployment chart template #551

Closed
jrmercier1 opened this issue Apr 26, 2019 · 1 comment · Fixed by #553 · May be fixed by MaxMood96/kubernetes-ingress#12
Closed
Labels
proposal An issue that proposes a feature request

Comments

@jrmercier1
Copy link

Is your feature request related to a problem? Please describe.
Feature

Describe the solution you'd like
I would like the ability to include custom(extra) pod spec annotations when deploying plus ingress via the helm chart deployment/daemonset.

Since plus tends to have different calls/api paths/port to pull stats than regular nginx ingress we have a couple monitoring solutions that require annotation overrides. In this case annotations in the .spec.templates.metadata or pod spec. Pod spec may make more sense due to also the fact prometheus-exporter may need different annotations.

Describe alternatives you've considered
Currently I edit the chart before deployment which long term defeats the purpose of relying on the published chart.

@pleshakov pleshakov added the proposal An issue that proposes a feature request label Apr 26, 2019
@Rulox Rulox closed this as completed in #553 May 2, 2019
@Rulox
Copy link
Contributor

Rulox commented May 2, 2019

Hi @jrmercier,

Now you can add custom annotations in the IC pods using the Helm Chart. This feature is available in the edge version of the IC. Check Releases for more info regarding versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal An issue that proposes a feature request
Projects
None yet
3 participants