Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lease instead of a configmap to acquire leader election lock #4295

Closed
shaun-nx opened this issue Aug 25, 2023 · 6 comments
Closed

Use lease instead of a configmap to acquire leader election lock #4295

shaun-nx opened this issue Aug 25, 2023 · 6 comments
Labels
proposal An issue that proposes a feature request

Comments

@shaun-nx
Copy link
Contributor

Is your feature request related to a problem? Please describe.
TBD

Describe the solution you'd like
TBD

Describe alternatives you've considered
TBD

Additional context
TBD

@shaun-nx shaun-nx added the proposal An issue that proposes a feature request label Aug 25, 2023
@github-actions
Copy link

Hi @shaun-nx thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@brianehlert brianehlert reopened this Feb 20, 2024
@brianehlert
Copy link
Collaborator

I see automation closed this.
However, I am curious if this is indeed something that needs to be addressed to catch up with K8s.

@brianehlert
Copy link
Collaborator

Looks like this was implemented with #4276
Is that correct?

@vepatel
Copy link
Contributor

vepatel commented Feb 21, 2024

@brianehlert yes this one can be closed 👍🏼

@oseoin
Copy link
Contributor

oseoin commented May 15, 2024

Closing as completed in #4276

@oseoin oseoin closed this as completed May 15, 2024
@brianehlert
Copy link
Collaborator

I am fishing if configmap still works at all?
Since I understand the command line option is still present, which implies the configmap code is still present.
And thus to potential for someone to use both configmap and lease at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal An issue that proposes a feature request
Projects
None yet
Development

No branches or pull requests

4 participants