Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stub_status and control status & API ports #339

Closed
isaachawley opened this issue Aug 15, 2018 · 3 comments
Closed

Enable stub_status and control status & API ports #339

isaachawley opened this issue Aug 15, 2018 · 3 comments
Assignees
Labels
enhancement Pull requests for new features/feature enhancements

Comments

@isaachawley
Copy link
Contributor

In some IC deployments the hard-coded ports for the NGINX+ API conflict with other services already running on those containers, and the NGINX open source stub_status isn't exposed at all.

We'll add 2 CLI options:

  • nginx-status-port the port to listen on
  • nginx-status which enables/disables the api or stub_status. If disabled, we'll listen on a unix socket instead, so the IC can still use api features.

The stub_status location will be added in a separate server directive in the nginx config, similar to the existing NGINX Plus API location.

We'll need to extend the NGINX Plus go sdk to handle linux sockets.

@isaachawley isaachawley added the enhancement Pull requests for new features/feature enhancements label Aug 15, 2018
@isaachawley isaachawley self-assigned this Aug 15, 2018
@isaachawley isaachawley mentioned this issue Aug 15, 2018
6 tasks
@isaachawley
Copy link
Contributor Author

This is done and merged:
#344

@ghost
Copy link

ghost commented Sep 8, 2018

Is above changes are present in this docker image version nginx/nginx-ingress:1.3.0.
I am not able to use the above two options. if provided as arguments, ic is failing to start by printing the help.
but ideally it should export the metrics on port 8080. even that configurations is not present and not working.

@isaachawley
Copy link
Contributor Author

Hi @vinodhbasavani please make an issue with your setup and steps to reproduce the issue.

But no, these changes are not in release 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

No branches or pull requests

1 participant