Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] terminationGracePeriodSeconds is missing in the helm deployment #2638

Closed
maksym-iv opened this issue Apr 29, 2022 · 1 comment · Fixed by #2637
Closed

[BUG] terminationGracePeriodSeconds is missing in the helm deployment #2638

maksym-iv opened this issue Apr 29, 2022 · 1 comment · Fixed by #2637

Comments

@maksym-iv
Copy link
Contributor

Describe the bug
terminationGracePeriodSeconds is missing in the deployment

To Reproduce
Steps to reproduce the behavior:

  1. Open deployments/helm-chart/templates/controller-deployment.yaml
  2. Search for the terminationGracePeriodSeconds
  3. No terminationGracePeriodSeconds attribute is defined

Expected behavior
terminationGracePeriodSeconds attribute should be present in the deployment resource as in daemonset resource

Your environment
N/A

Additional context
Opened PR #2637
@github-actions
Copy link

Hi @maksym-iv thanks for reporting!

Be sure to check out the docs while you wait for a human to take a look at this 🙂

Cheers!

@brianehlert brianehlert linked a pull request May 3, 2022 that will close this issue
Add terminationGracePeriodSeconds to deployment #2637
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add terminationGracePeriodSeconds to deployment maksym-iv/kubernetes-ingress
1 participant
@maksym-iv