Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container Image vulnerabilities #232

Closed
ghost opened this issue Jan 29, 2018 · 7 comments
Closed

container Image vulnerabilities #232

ghost opened this issue Jan 29, 2018 · 7 comments

Comments

@ghost
Copy link

ghost commented Jan 29, 2018

Hi @pleshakov

we make use of multiple NGINX plus instances in google kubernetes engine. Google recently added a vulnerability scanner to its image registry.

As you can see in the image below it detected 93 vulnerabilities of which 6 Critical, 19 High, 50 Medium, 6 Low and 12 Unknown in severity.

image

I'm not sure if this affects the running NGINX process at all, but I think this should be fixed.
If I can be of any assistance, let me know.

~ Rob

@pleshakov
Copy link
Contributor

@rjrhaverkamp

Please rebuild your image to use the latest version of ubuntu:16:04 to make sure you have the latest version of all packages. If you're using the Makefile to build the Ingress controller image, we've added the DOCKER_BUILD_OPTIONS, so that you can run $make DOCKER_BUILD_OPTIONS=--pull ... to make sure that the docker build command will pull the latest version of the base image ubuntu:16:04. This way we can minimize the number of vulnerabilities.

As an NGINX Plus customer you can get support directly from us. If you prefer, you can create a support ticket, using the email addresses (for you and for NGINX engineering) in your support contract to send and receive support case information.

@ghost
Copy link
Author

ghost commented Jan 30, 2018

Hi @pleshakov

All vulnerabilities that have a patch available are now fixed. There are still 3 critical in severity and 13 high found, but according to the scanner these don't have a patch available.

Thanks!

@ghost ghost closed this as completed Jan 30, 2018
@thresheek
Copy link
Member

Another option would be to move to a slimmer version of a base distro - e.g. debian:stretch-slim - which hopefully will have less of an attack surface. Also removing everything install during the build of the image is a good idea to minimize that issue as well. Unfortunately there is no good way other than rebuilding an image every once in a while.

@pleshakov
Copy link
Contributor

@rjrhaverkamp please check https://github.com/nginxinc/kubernetes-ingress/blob/plus-dockerfiles/nginx-controller/DockerfileForPlusStretch for a DockerFile for debian:stretch-slim Soon we will make it as the default DockerFileForPlus instead of the Ubuntu 16.04 -based one.

@ghost
Copy link
Author

ghost commented Jan 30, 2018

The first image is a scan of the Ubuntu 16:04 image(with the latest version pulled). The second image is the Debian Stretch image. It's a huge improvement. Thanks! 👍

screen shot 2018-01-30 at 13 36 16

screen shot 2018-01-30 at 13 35 42

@thresheek
Copy link
Member

I wonder if that image scanner takes into account actual patches in the debian packages - and not only the versions.. But indeed, it looks miles better.

@pleshakov
Copy link
Contributor

the image for Plus now uses Debian Stretch -- 0dafb34

pleshakov referenced this issue Feb 9, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants