-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make nginx.tmpl support dynamic modules #212
Comments
@kongdewen to support a dynamic module, you need build your own image of the Ingress controller with some changes in the following files:
Additionally, to configure the module it might be necessary to further change |
Thanks @pleshakov. Yea, we can do this. our current thought is to stay with the upstream as much as we can, so for the future upgrade/maintenance, we can easily pull from upstream. we already have http-snippets, server-snippets, location snippets, why don't we have some snippet also for core functionalities? we would be happy to contribute here(making PRs such). |
@kongdewen I see your point. It makes sense to have a ConfigMap key like |
Thanks @pleshakov I made a PR. #213. |
Any chance to make it happen?
The text was updated successfully, but these errors were encountered: