Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nginx.tmpl support dynamic modules #212

Closed
kongdewen opened this issue Nov 13, 2017 · 4 comments
Closed

Make nginx.tmpl support dynamic modules #212

kongdewen opened this issue Nov 13, 2017 · 4 comments

Comments

@kongdewen
Copy link

Any chance to make it happen?

@pleshakov
Copy link
Contributor

@kongdewen to support a dynamic module, you need build your own image of the Ingress controller with some changes in the following files:

  • Dockerfile - install/include the module binary
  • nginx.tmpl - load the module binary using the load_module directive.

Additionally, to configure the module it might be necessary to further change nginx.tmpl or nginx.ingress.tmpl files. Alternatively, you can use the snippets annotations and the config map key. See https://github.com/nginxinc/kubernetes-ingress/tree/master/examples/customization

@kongdewen
Copy link
Author

Thanks @pleshakov. Yea, we can do this. our current thought is to stay with the upstream as much as we can, so for the future upgrade/maintenance, we can easily pull from upstream. we already have http-snippets, server-snippets, location snippets, why don't we have some snippet also for core functionalities?

we would be happy to contribute here(making PRs such).

@pleshakov
Copy link
Contributor

@kongdewen I see your point. It makes sense to have a ConfigMap key like main-snippets for inserting a custom snippet into the main context. I'd be happy to review the PR.

@kongdewen
Copy link
Author

Thanks @pleshakov I made a PR. #213.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants